Re: Dead code in ES Sink

Posted by Aljoscha Krettek on
URL: http://deprecated-apache-flink-user-mailing-list-archive.369.s1.nabble.com/Dead-code-in-ES-Sink-tp40585p40651.html

On 2021/01/13 07:50, Rex Fenley wrote:
>Are you saying that this option does get passed along to Elasticsearch
>still or that it's just arbitrarily validated? According to [1] it's been
>deprecated in ES 6 and removed in ES 7.
>
>[1] https://github.com/elastic/elasticsearch/pull/38085

Sorry, I wasn't being very clear. I meant that we just pass it on to ES.  
In light of it being deprecated, I think it makes sense to keep it as
long as we support ES 6. What do you think?

Side note: we still have an ES 5 connector... 😅 There was a discussion
about dropping it, but it wasn't conclusive. [1]

[1]
https://lists.apache.org/thread.html/rb957e7d7d5fb9bbe25e5fbc56662749ee1bc551d36e26c58644f60d4%40%3Cdev.flink.apache.org%3E

Best,
Aljoscha