Re: Dead code in ES Sink

Posted by Aljoscha Krettek on
URL: http://deprecated-apache-flink-user-mailing-list-archive.369.s1.nabble.com/Dead-code-in-ES-Sink-tp40585p40604.html

On 2021/01/12 15:04, Rex Fenley wrote:
>[2]
>https://github.com/apache/flink/blob/97bfd049951f8d52a2e0aed14265074c4255ead0/flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/ElasticsearchOptions.java#L131
>
>Should [2] be removed?

The link seems to not work anymore but I'm guessing you're referring to
`CONNECTION_MAX_RETRY_TIMEOUT_OPTION`. This is used in the
`*DynamicSinkFactory` classes, such as [1]. These can be used when
defining Table API/SQL sources using DDL or the programmatic API. The
actual field is never used but it will be used to check the allowed
options when verifying what users specify via "string" options.

[1]
https://github.com/apache/flink/blob/ee653778689023ddfdf007d5bde1daad8fbbc081/flink-connectors/flink-connector-elasticsearch7/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch7DynamicSinkFactory.java#L98