Dead code in ES Sink

Posted by Rex Fenley on
URL: http://deprecated-apache-flink-user-mailing-list-archive.369.s1.nabble.com/Dead-code-in-ES-Sink-tp40585.html

Hi,

I was looking through ES options trying to diagnose a SocketTimeOut we're receiving on the ES TableAPI connector. A bug report on elasticsearch's github[1] indicated I might want to set max retry timeout really high, but from what I can tell it's not even consumed anywhere [2].

[1] https://github.com/elastic/elasticsearch/issues/33342

[2] https://github.com/apache/flink/blob/97bfd049951f8d52a2e0aed14265074c4255ead0/flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/ElasticsearchOptions.java#L131

Should [2] be removed?

--