Re: checkpoint notifier not found?

Posted by abhishekrs on
URL: http://deprecated-apache-flink-user-mailing-list-archive.369.s1.nabble.com/checkpoint-notifier-not-found-tp10570p10633.html

Is this more appropriate for dev list? Anyway here is my first:

https://github.com/apache/flink/pull/3006

On Dec 14, 2016, at 2:38 AM, Robert Metzger <[hidden email]> wrote:

Hi Abhishek,

you can not push to the Flink repository directly. Only Flink committers are allowed to do that.

But you can fork the Flink repository on github to your own GitHub account and then push the changes to your Github.

Then, you can create a pull request to offer those changes to the main Flink repository.

On Wed, Dec 14, 2016 at 1:20 AM, Abhishek R. Singh <[hidden email]> wrote:

Not sure how to go from here. How do I create a PR for this?

$ git branch

* doc-checkpoint-notify

  master

$ git push origin master

remote: Permission to apache/flink.git denied to abhishsi.

fatal: unable to access 'https://github.com/apache/flink.git/': The requested URL returned error: 403

$ git diff HEAD^1

diff --git a/docs/dev/state.md b/docs/dev/state.md

index 37de0a8..a753ed1 100644

--- a/docs/dev/state.md

+++ b/docs/dev/state.md

@@ -281,7 +281,7 @@ public static class CounterSource

 }

 {% endhighlight %}

 

-Some operators might need the information when a checkpoint is fully acknowledged by Flink to communicate that with the outside world. In this case see the `flink.streaming.api.checkpoint.CheckpointNotifier` interface.

+Some operators might need the information when a checkpoint is fully acknowledged by Flink to communicate that with the outside world. In this case see the `org.apache.flink.runtime.state.CheckpointListener` interface.

 

 ## State Checkpoints in Iterative Jobs

 

On Dec 12, 2016, at 3:11 PM, Abhishek R. Singh <[hidden email]> wrote:

https://issues.apache.org/jira/browse/FLINK-5323

On Dec 12, 2016, at 5:37 AM, Till Rohrmann <[hidden email]> wrote:

Hi Abhishek,

great to hear that you like to become part of the Flink community. Here are some information for how to contribute [1].

[1] http://flink.apache.org/how-to-contribute.html

Cheers,

Till

On Mon, Dec 12, 2016 at 12:36 PM, Abhishek Singh <[hidden email]> wrote:

Will be happy to. Could you guide me a bit in terms of what I need to do?

I am a newbie to open source contributing. And currently at Frankfurt airport. When I hit ground will be happy to contribute back. Love the project !!

Thanks for the awesomeness. 

On Mon, Dec 12, 2016 at 12:29 PM Stephan Ewen <[hidden email]> wrote:

Thanks for reporting this.

It would be awesome if you could file a JIRA or a pull request for fixing the docs for that.

On Sat, Dec 10, 2016 at 2:02 AM, Abhishek R. Singh <[hidden email]> wrote:

I was following the official documentation: https://ci.apache.org/projects/flink/flink-docs-release-1.1/apis/streaming/state.html

Looks like this is the right one to be using: import org.apache.flink.runtime.state.CheckpointListener;

-Abhishek-

On Dec 9, 2016, at 4:30 PM, Abhishek R. Singh <[hidden email]> wrote:

I can’t seem to find CheckpointNotifier. Appreciate help !

CheckpointNotifier is not a member of package org.apache.flink.streaming.api.checkpoint

From my pom.xml:

        <dependency>

                <groupId>org.apache.flink</groupId>

                <artifactId>flink-scala_2.11</artifactId>

                <version>1.1.3</version>

        </dependency>

        <dependency>

                <groupId>org.apache.flink</groupId>

                <artifactId>flink-streaming-scala_2.11</artifactId>

                <version>1.1.3</version>

        </dependency>

        <dependency>

                <groupId>org.apache.flink</groupId>

                <artifactId>flink-clients_2.11</artifactId>

                <version>1.1.3</version>

        </dependency>

        <dependency>

                <groupId>org.apache.flink</groupId>

                <artifactId>flink-statebackend-rocksdb_2.11</artifactId>

                <version>1.1.3</version>

        </dependency>