sharebuffer prune code

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

sharebuffer prune code

aitozi
Hi,

i am running into a cep bug : it always running into failed to find previous
sharebufferEntry, i think it may be caused by prune the sharebufferEntry
wrongly, but when i read the code, i cant understand this :
https://gist.github.com/Aitozi/007210bc7ade01a81f8d0fc4ba5a2c99

why when encounted a entry with timestamp > pruningTimestamp, we should
break the whole prune loop (set the continuePruning to false )

thanks,
aitozi



--
Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: sharebuffer prune code

Kostas Kloudas
Hi Aitozi,

I think you are correct.
Could you open a JIRA and share it here?

Thanks,
Kostas

> On Apr 2, 2018, at 7:19 AM, aitozi <[hidden email]> wrote:
>
> Hi,
>
> i am running into a cep bug : it always running into failed to find previous
> sharebufferEntry, i think it may be caused by prune the sharebufferEntry
> wrongly, but when i read the code, i cant understand this :
> https://gist.github.com/Aitozi/007210bc7ade01a81f8d0fc4ba5a2c99
>
> why when encounted a entry with timestamp > pruningTimestamp, we should
> break the whole prune loop (set the continuePruning to false )
>
> thanks,
> aitozi
>
>
>
> --
> Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/

Reply | Threaded
Open this post in threaded view
|

Re: sharebuffer prune code

aitozi
OK, i will post a jira later. and i am foucs on cep library recently, and run
into a little bug, and can you share some progress about the community of
cep library and what feature you are working on

thanks



--
Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: sharebuffer prune code

Shailesh Jain
Hi guys,

Were you able to RCA this? I think I'm hitting the same issue on 1.4.0, but not really able to reproduce it through a test case.
In an IterativeCondition (using AfterMatchSkipStrategy.skipPastLastEvent), while looking up previously matched events, it is hitting a java.util.NoSuchElementException

Any leads on this issue would be of great help.

Thanks,
Shailesh

On Mon, Apr 9, 2018 at 8:53 AM, aitozi <[hidden email]> wrote:
OK, i will post a jira later. and i am foucs on cep library recently, and run
into a little bug, and can you share some progress about the community of
cep library and what feature you are working on

thanks

Reply | Threaded
Open this post in threaded view
|

Re: sharebuffer prune code

aitozi
Can you explain it more explictly?



--
Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: sharebuffer prune code

Dawid Wysakowicz-2
The logic for SharedBuffer and in result for prunning will be changed in
FLINK-9418 [1]. We plan to make it backwards compatible. There is
already open PR[2] (in review), you can check if the problem persists.

Regards,
Dawid

[1] https://issues.apache.org/jira/browse/FLINK-9418
[2] https://github.com/apache/flink/pull/6059


On 24.05.2018 12:21, aitozi wrote:
> Can you explain it more explictly?
>
>
>
> --
> Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/



signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: sharebuffer prune code

Shailesh Jain
Thanks Dawid. I'll rebase against your branch and test it. Would revert back if I hit the issue again.

Regards,
Shailesh

On Sun, May 27, 2018 at 5:54 PM, Dawid Wysakowicz <[hidden email]> wrote:
The logic for SharedBuffer and in result for prunning will be changed in
FLINK-9418 [1]. We plan to make it backwards compatible. There is
already open PR[2] (in review), you can check if the problem persists.

Regards,
Dawid

[1] https://issues.apache.org/jira/browse/FLINK-9418
[2] https://github.com/apache/flink/pull/6059


On 24.05.2018 12:21, aitozi wrote:
> Can you explain it more explictly?
>
>
>
> --
> Sent from: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/