Visibility of FileInputFormat constants

[Flavio Pompermaier]

Hi to all,

in my program I need to set "recursive.file.enumeration" to true and I discovered that there's a constant for that variable in FileInputFormat (ENUMERATE_NESTED_FILES_FLAG) but it's private. Do you think it could be a good idea to change it's visibility to public?

Best,

Flavio

[Fabian Hueske-2]

Definitely! Much better than using the String value.

2015-05-26 16:55 GMT+02:00 Flavio Pompermaier <[hidden email]>:

Hi to all,

in my program I need to set "recursive.file.enumeration" to true and I discovered that there's a constant for that variable in FileInputFormat (ENUMERATE_NESTED_FILES_FLAG) but it's private. Do you think it could be a good idea to change it's visibility to public?

Best,

Flavio

[Flavio Pompermaier]

Could you do that so I can avoid to make a PR just for that, please?

On Tue, May 26, 2015 at 4:58 PM, Fabian Hueske <[hidden email]> wrote:

Definitely! Much better than using the String value.

2015-05-26 16:55 GMT+02:00 Flavio Pompermaier <[hidden email]>:

Hi to all,

in my program I need to set "recursive.file.enumeration" to true and I discovered that there's a constant for that variable in FileInputFormat (ENUMERATE_NESTED_FILES_FLAG) but it's private. Do you think it could be a good idea to change it's visibility to public?

Best,

Flavio

[Fabian Hueske-2]

Done

2015-05-26 16:59 GMT+02:00 Flavio Pompermaier <[hidden email]>:

Could you do that so I can avoid to make a PR just for that, please?

On Tue, May 26, 2015 at 4:58 PM, Fabian Hueske <[hidden email]> wrote:

Definitely! Much better than using the String value.

2015-05-26 16:55 GMT+02:00 Flavio Pompermaier <[hidden email]>:

Hi to all,

in my program I need to set "recursive.file.enumeration" to true and I discovered that there's a constant for that variable in FileInputFormat (ENUMERATE_NESTED_FILES_FLAG) but it's private. Do you think it could be a good idea to change it's visibility to public?

Best,

Flavio

[Flavio Pompermaier]

Thanks ;)

On Tue, May 26, 2015 at 5:08 PM, Fabian Hueske <[hidden email]> wrote:

Done

2015-05-26 16:59 GMT+02:00 Flavio Pompermaier <[hidden email]>:

Could you do that so I can avoid to make a PR just for that, please?

On Tue, May 26, 2015 at 4:58 PM, Fabian Hueske <[hidden email]> wrote:

Definitely! Much better than using the String value.

2015-05-26 16:55 GMT+02:00 Flavio Pompermaier <[hidden email]>:

Hi to all,

in my program I need to set "recursive.file.enumeration" to true and I discovered that there's a constant for that variable in FileInputFormat (ENUMERATE_NESTED_FILES_FLAG) but it's private. Do you think it could be a good idea to change it's visibility to public?

Best,

Flavio