I forked Flink to work on a PR. When I run `mvn clean package` from a clean branch, Maven says the runtime tests failed but the logs do not appear to have details on the failure. Do I have to do anything to run these?
... [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.24 s - in org.apache.flink.runtime.taskexecutor.BackPressureSampleServiceTest [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.872 s - in org.apache.flink.runtime.taskexecutor.partition.PartitionTableTest [DEBUG] Forking command line: /bin/sh -c cd /Users/quietgolfer/code/dan-flink/flink/flink-runtime && /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre/bin/java -Xms256m -Xmx2048m -Dmvn.forkNumber=9 -XX:+UseG1GC -jar /Users/quietgolfer/code/dan-flink/flink/flink-runtime/target/surefire/surefirebooter3345042301183877750.jar /Users/quietgolfer/code/dan-flink/flink/flink-runtime/target/surefire 2020-10-19T23-54-59_239-jvmRun9 surefire7884081050263655575tmp surefire_7142433009722615751420tmp [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2 s - in org.apache.flink.runtime.taskexecutor.slot.TaskSlotTest [INFO] Running org.apache.flink.runtime.taskexecutor.NettyShuffleEnvironmentConfigurationTest [INFO] Running org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImplTest [INFO] Running org.apache.flink.runtime.taskexecutor.TaskExecutorToResourceManagerConnectionTest [INFO] Running org.apache.flink.runtime.taskexecutor.slot.TimerServiceTest [INFO] Running akka.actor.RobustActorSystemTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.077 s - in org.apache.flink.runtime.taskexecutor.NettyShuffleEnvironmentConfigurationTest [INFO] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.009 s - in org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImplTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.088 s - in org.apache.flink.runtime.taskexecutor.slot.TimerServiceTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.986 s - in org.apache.flink.runtime.taskexecutor.TaskExecutorToResourceManagerConnectionTest [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.146 s - in akka.actor.RobustActorSystemTest [INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.309 s - in org.apache.flink.runtime.taskexecutor.TaskExecutorTest [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.068 s - in org.apache.flink.runtime.taskexecutor.TaskManagerRunnerTest [INFO] [INFO] Results: [INFO] [WARNING] Tests run: 4813, Failures: 0, Errors: 0, Skipped: 50 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Flink : 1.12-SNAPSHOT: [INFO] [INFO] Flink : Tools : Force Shading ...................... SUCCESS [ 1.736 s] [INFO] Flink : ............................................ SUCCESS [ 15.601 s] [INFO] Flink : Annotations ................................ SUCCESS [ 14.502 s] [INFO] Flink : Test utils : ............................... SUCCESS [ 12.505 s] [INFO] Flink : Test utils : Junit ......................... SUCCESS [ 15.152 s] [INFO] Flink : Metrics : .................................. SUCCESS [ 12.443 s] [INFO] Flink : Metrics : Core ............................. SUCCESS [ 14.250 s] [INFO] Flink : Core ....................................... SUCCESS [01:23 min] [INFO] Flink : Java ....................................... SUCCESS [ 43.248 s] [INFO] Flink : Queryable state : .......................... SUCCESS [ 10.139 s] [INFO] Flink : Queryable state : Client Java .............. SUCCESS [ 16.857 s] [INFO] Flink : FileSystems : .............................. SUCCESS [ 13.203 s] [INFO] Flink : FileSystems : Hadoop FS .................... SUCCESS [ 25.514 s] [INFO] Flink : Runtime .................................... FAILURE [11:05 min] [INFO] Flink : Scala ...................................... SKIPPED |
Hi Dan, The 'mvn package' command automatically includes 'mvn verify', which triggers the test cases. You can skip the tests with 'mvn package -DskipTests'. You can rely on the ci-tests running on Azure Pipeline, either in your own workspace or in the PR. If it is intended to execute the tests locally, you can try the following actions. I'm not sure whether that helps though. - Try to add '-DfailIfNoTests=false' to your maven command. - Execute the maven command with '-X' to print all the debug logs. Thank you~ Xintong Song On Tue, Oct 20, 2020 at 3:48 PM Dan Hill <[hidden email]> wrote:
|
Hi Xintong! Thanks! - Dan On Tue, Oct 20, 2020 at 8:22 AM Xintong Song <[hidden email]> wrote:
|
Would you be able to share the complete maven logs and the command? And what is the maven version? Thank you~ Xintong Song On Wed, Oct 21, 2020 at 1:37 AM Dan Hill <[hidden email]> wrote:
|
Sure, here's a link to the output. I think for this one I used either: - `mvn package -e -X -DfailIfNoTests=false` - or added a `clean` before package. On Wed, Oct 21, 2020 at 2:24 AM Xintong Song <[hidden email]> wrote:
|
Hi Dan, It looks like while your tests are executed and passed, the java processes executing those tests did not exit properly. - Could you try execute the command manually and see if there's any useful outputs? You can find the commands by searching "Command was" in the maven logs. - Quick question: which PR are you working on? By any chance you called `System.exit()` in your codes? Thank you~ Xintong Song On Thu, Oct 22, 2020 at 5:59 AM Dan Hill <[hidden email]> wrote:
|
On Wed, Oct 21, 2020 at 7:11 PM Xintong Song <[hidden email]> wrote:
|
Hi Dan, I tried with the PR you pointed out, and cannot reproduce the problem. So it should not be related to the PR codes. I'm running with maven 3.2.5, which is the same version that we use for running ci tests on AZP for PRs. Your maven log suggests the maven version on your machine is 3.6.3. I'm not sure whether the maven version is related, but maybe you can try it out with 3.2.5. And if it turns out worked, we may fire a issue at the Apache Maven community. Thank you~ Xintong Song On Thu, Oct 22, 2020 at 12:31 PM Dan Hill <[hidden email]> wrote:
|
Changing down to maven 3.2 shows an error. It seems like I'm hitting flaky tests. I hit one error and then a different error when running again. I'm not blocked now. My diff was already merged and the related tests pass. Neither of these failures look related to my diff. <<< FAILURE! - in org.apache.flink.orc.OrcColumnarRowSplitReaderTest [ERROR] testReadFileWithTypes(org.apache.flink.orc.OrcColumnarRowSplitReaderTest) Time elapsed: 1.833 s <<< FAILURE! org.junit.ComparisonFailure: expected:<19[69-12-3]1> but was:<19[70-01-0]1> at org.junit.Assert.assertEquals(Assert.java:115) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.flink.orc.OrcColumnarRowSplitReaderTest.testReadFileWithTypes(OrcColumnarRowSplitReaderTest.java:371) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) My next run, this test fails. The test doesn't exist anymore so I'm guessing it might be an issue with my head. Expected: a value less than or equal to <160290L> but: <336174L> was greater than <160290L> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8) at org.apache.flink.streaming.runtime.io.AlternatingCheckpointBarrierHandlerTest.assertMetrics(AlternatingCheckpointBarrierHandlerTest.java:212) at org.apache.flink.streaming.runtime.io.AlternatingCheckpointBarrierHandlerTest.testMetricsAlternation(AlternatingCheckpointBarrierHandlerTest.java:120) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRu On Thu, Oct 22, 2020 at 8:49 PM Xintong Song <[hidden email]> wrote:
|
Hi Dan, I think these are unstable test cases. As we are approaching the feature freeze date for release 1.12.0, people are busy merging new features recently, which lead to the test instability. I'm not aware of any issue reported on the `OrcColumnarRowSplitReaderTest`. From what you described, this does not always happen on your machine. You may want to fire an issue on it if you still have the complete maven logs. For `AlternatingCheckpointBarrierHandlerTest`, there is already an issue [1] reported on its instability. As long as you do not run into the VM crash problems, I think it should be fine. Thank you~ Xintong Song On Sat, Oct 24, 2020 at 5:56 AM Dan Hill <[hidden email]> wrote:
|
Free forum by Nabble | Edit this page |