Missing annotation in SimpleJdbcConnectionProvider.java ?

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Missing annotation in SimpleJdbcConnectionProvider.java ?

Kenzyme
Hi,

I would like to know if class SimpleJdbcConnectionProvider.java should be marked as @Internal or @PublicEvolving? Since there's annotation provided, I'm unsure if I should be using this class in my user code.

If one of them is missing, I would like to create a PR for this if that's fine as well.

Thank you for the clarification!

Kenzyme Le


Reply | Threaded
Open this post in threaded view
|

Re: Missing annotation in SimpleJdbcConnectionProvider.java ?

Kenzyme
After careful examination, seems like it should be marked as @Internal since this class is located in package org.apache.flink.connector.jdbc.internal.connection.

Here is my PR related to this https://github.com/apache/flink/pull/13603 .

Thanks a lot!

Kenzyme Le


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, October 12th, 2020 at 10:48 PM, Kenzyme <[hidden email]> wrote:
Hi,

I would like to know if class SimpleJdbcConnectionProvider.java should be marked as @Internal or @PublicEvolving? Since there's annotation provided, I'm unsure if I should be using this class in my user code.

If one of them is missing, I would like to create a PR for this if that's fine as well.

Thank you for the clarification!

Kenzyme Le