FlinkCounterWrapper

[Richard Moorhead]

We have a use case wherein counters emitted by flink are decremented after being reported. In this way we report only the change in the counter. Currently it seems that FlinkCounterWrapper doesnt mutate the wrapped counter when either inc or dec is called; would this be a valid improvement?


https://github.com/apache/flink/blob/master/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/metrics/FlinkCounterWrapper.java

[Richard Moorhead]

Furthermore, it looks like the rest of the dropwizard wrappers all have the mutators implemented.

https://issues.apache.org/jira/browse/FLINK-19497

On Fri, Oct 2, 2020 at 2:30 PM Richard Moorhead <[hidden email]> wrote:

We have a use case wherein counters emitted by flink are decremented after being reported. In this way we report only the change in the counter. Currently it seems that FlinkCounterWrapper doesnt mutate the wrapped counter when either inc or dec is called; would this be a valid improvement?


https://github.com/apache/flink/blob/master/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/metrics/FlinkCounterWrapper.java