[DISCUSS] Drop vendor specific repositories from pom.xml

[Till Rohrmann]

Hi everyone,

following the discussion started by Seth [1] I would like to discuss dropping the vendor specific repositories from Flink's parent pom.xml. As building Flink against a vendor specific Hadoop version is no longer needed (as it simply needs to be added to the classpath) and documented, I believe that the vendor specific repositories and the mapr profile have become obsolete. Moreover, users can still use vendor specific Hadoop versions if they configure their local maven to point to the respective repository [2]. Flink's sources would simply no longer be shipped with this option.

Are there any concerns about dropping the vendor specific repositories from pom.xml? I would like to make this change for the upcoming Flink 1.10 release if possible.

[1] https://lists.apache.org/thread.html/83afcf6c0d5d7a0a7179cbdac9593ebe7478b0dc548781bf9915a006%40%3Cdev.flink.apache.org%3E

[2] https://maven.apache.org/guides/mini/guide-multiple-repositories.html

Cheers,

Till

[rmetzger0]

I guess we are talking about this profile [1] in the pom.xml?

+1 to remove.

I'm not sure if we need to rush this for the 1.10 release. The profile is not doing us any harm at the moment.

[1]https://github.com/apache/flink/blob/master/pom.xml#L1035

On Wed, Dec 18, 2019 at 4:51 PM Till Rohrmann <[hidden email]> wrote:

Hi everyone,

following the discussion started by Seth [1] I would like to discuss
dropping the vendor specific repositories from Flink's parent pom.xml. As
building Flink against a vendor specific Hadoop version is no longer needed
(as it simply needs to be added to the classpath) and documented, I believe
that the vendor specific repositories and the mapr profile have become
obsolete. Moreover, users can still use vendor specific Hadoop versions if
they configure their local maven to point to the respective repository [2].
Flink's sources would simply no longer be shipped with this option.

Are there any concerns about dropping the vendor specific repositories from
pom.xml? I would like to make this change for the upcoming Flink 1.10
release if possible.

[1]
https://lists.apache.org/thread.html/83afcf6c0d5d7a0a7179cbdac9593ebe7478b0dc548781bf9915a006%40%3Cdev.flink.apache.org%3E
[2] https://maven.apache.org/guides/mini/guide-multiple-repositories.html

Cheers,
Till

[Till Rohrmann]

The profiles make bumping ZooKeeper's version a bit more cumbersome. I would be interested for this reason to get rid of them, too.

Cheers,

Till

On Wed, Dec 18, 2019 at 5:35 PM Robert Metzger <[hidden email]> wrote:

I guess we are talking about this profile [1] in the pom.xml?

+1 to remove.

I'm not sure if we need to rush this for the 1.10 release. The profile is not doing us any harm at the moment.

[1]https://github.com/apache/flink/blob/master/pom.xml#L1035

On Wed, Dec 18, 2019 at 4:51 PM Till Rohrmann <[hidden email]> wrote:

Hi everyone,

following the discussion started by Seth [1] I would like to discuss
dropping the vendor specific repositories from Flink's parent pom.xml. As
building Flink against a vendor specific Hadoop version is no longer needed
(as it simply needs to be added to the classpath) and documented, I believe
that the vendor specific repositories and the mapr profile have become
obsolete. Moreover, users can still use vendor specific Hadoop versions if
they configure their local maven to point to the respective repository [2].
Flink's sources would simply no longer be shipped with this option.

Are there any concerns about dropping the vendor specific repositories from
pom.xml? I would like to make this change for the upcoming Flink 1.10
release if possible.

[1]
https://lists.apache.org/thread.html/83afcf6c0d5d7a0a7179cbdac9593ebe7478b0dc548781bf9915a006%40%3Cdev.flink.apache.org%3E
[2] https://maven.apache.org/guides/mini/guide-multiple-repositories.html

Cheers,
Till

[rmetzger0]

Okay, I understand. I'm okay with removing the profile.

On Thu, Dec 19, 2019 at 11:34 AM Till Rohrmann <[hidden email]> wrote:

The profiles make bumping ZooKeeper's version a bit more cumbersome. I would be interested for this reason to get rid of them, too.

Cheers,

Till

On Wed, Dec 18, 2019 at 5:35 PM Robert Metzger <[hidden email]> wrote:

I guess we are talking about this profile [1] in the pom.xml?

+1 to remove.

I'm not sure if we need to rush this for the 1.10 release. The profile is not doing us any harm at the moment.

[1]https://github.com/apache/flink/blob/master/pom.xml#L1035

On Wed, Dec 18, 2019 at 4:51 PM Till Rohrmann <[hidden email]> wrote:

Hi everyone,

following the discussion started by Seth [1] I would like to discuss
dropping the vendor specific repositories from Flink's parent pom.xml. As
building Flink against a vendor specific Hadoop version is no longer needed
(as it simply needs to be added to the classpath) and documented, I believe
that the vendor specific repositories and the mapr profile have become
obsolete. Moreover, users can still use vendor specific Hadoop versions if
they configure their local maven to point to the respective repository [2].
Flink's sources would simply no longer be shipped with this option.

Are there any concerns about dropping the vendor specific repositories from
pom.xml? I would like to make this change for the upcoming Flink 1.10
release if possible.

[1]
https://lists.apache.org/thread.html/83afcf6c0d5d7a0a7179cbdac9593ebe7478b0dc548781bf9915a006%40%3Cdev.flink.apache.org%3E
[2] https://maven.apache.org/guides/mini/guide-multiple-repositories.html

Cheers,
Till

[Aljoscha Krettek]

+1 to remove

> On 20. Dec 2019, at 10:34, Robert Metzger <[hidden email]> wrote:
>
> Okay, I understand. I'm okay with removing the profile.
>
> On Thu, Dec 19, 2019 at 11:34 AM Till Rohrmann <[hidden email]> wrote:
>
>> The profiles make bumping ZooKeeper's version a bit more cumbersome. I
>> would be interested for this reason to get rid of them, too.
>>
>> Cheers,
>> Till
>>
>> On Wed, Dec 18, 2019 at 5:35 PM Robert Metzger <[hidden email]>
>> wrote:
>>
>>> I guess we are talking about this profile [1] in the pom.xml?
>>>
>>> +1 to remove.
>>>
>>> I'm not sure if we need to rush this for the 1.10 release. The profile is
>>> not doing us any harm at the moment.
>>>
>>> [1]https://github.com/apache/flink/blob/master/pom.xml#L1035
>>>
>>> On Wed, Dec 18, 2019 at 4:51 PM Till Rohrmann <[hidden email]>
>>> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> following the discussion started by Seth [1] I would like to discuss
>>>> dropping the vendor specific repositories from Flink's parent pom.xml. As
>>>> building Flink against a vendor specific Hadoop version is no longer
>>>> needed
>>>> (as it simply needs to be added to the classpath) and documented, I
>>>> believe
>>>> that the vendor specific repositories and the mapr profile have become
>>>> obsolete. Moreover, users can still use vendor specific Hadoop versions
>>>> if
>>>> they configure their local maven to point to the respective repository
>>>> [2].
>>>> Flink's sources would simply no longer be shipped with this option.
>>>>
>>>> Are there any concerns about dropping the vendor specific repositories
>>>> from
>>>> pom.xml? I would like to make this change for the upcoming Flink 1.10
>>>> release if possible.
>>>>
>>>> [1]
>>>>
>>>> https://lists.apache.org/thread.html/83afcf6c0d5d7a0a7179cbdac9593ebe7478b0dc548781bf9915a006%40%3Cdev.flink.apache.org%3E
>>>> [2]
>>>> https://maven.apache.org/guides/mini/guide-multiple-repositories.html
>>>>
>>>> Cheers,
>>>> Till
>>>>
>>>

[Till Rohrmann]

Thanks for the feedback. As I haven't heard any objections, I'll open a JIRA issue and a PR to remove the vendor specific repositories.

Cheers,

Till

On Thu, Jan 2, 2020 at 12:28 PM Aljoscha Krettek <[hidden email]> wrote:

+1 to remove

> On 20. Dec 2019, at 10:34, Robert Metzger <[hidden email]> wrote:
>
> Okay, I understand. I'm okay with removing the profile.
>
> On Thu, Dec 19, 2019 at 11:34 AM Till Rohrmann <[hidden email]> wrote:
>
>> The profiles make bumping ZooKeeper's version a bit more cumbersome. I
>> would be interested for this reason to get rid of them, too.
>>
>> Cheers,
>> Till
>>
>> On Wed, Dec 18, 2019 at 5:35 PM Robert Metzger <[hidden email]>
>> wrote:
>>
>>> I guess we are talking about this profile [1] in the pom.xml?
>>>
>>> +1 to remove.
>>>
>>> I'm not sure if we need to rush this for the 1.10 release. The profile is
>>> not doing us any harm at the moment.
>>>
>>> [1]https://github.com/apache/flink/blob/master/pom.xml#L1035
>>>
>>> On Wed, Dec 18, 2019 at 4:51 PM Till Rohrmann <[hidden email]>
>>> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> following the discussion started by Seth [1] I would like to discuss
>>>> dropping the vendor specific repositories from Flink's parent pom.xml. As
>>>> building Flink against a vendor specific Hadoop version is no longer
>>>> needed
>>>> (as it simply needs to be added to the classpath) and documented, I
>>>> believe
>>>> that the vendor specific repositories and the mapr profile have become
>>>> obsolete. Moreover, users can still use vendor specific Hadoop versions
>>>> if
>>>> they configure their local maven to point to the respective repository
>>>> [2].
>>>> Flink's sources would simply no longer be shipped with this option.
>>>>
>>>> Are there any concerns about dropping the vendor specific repositories
>>>> from
>>>> pom.xml? I would like to make this change for the upcoming Flink 1.10
>>>> release if possible.
>>>>
>>>> [1]
>>>>
>>>> https://lists.apache.org/thread.html/83afcf6c0d5d7a0a7179cbdac9593ebe7478b0dc548781bf9915a006%40%3Cdev.flink.apache.org%3E
>>>> [2]
>>>> https://maven.apache.org/guides/mini/guide-multiple-repositories.html
>>>>
>>>> Cheers,
>>>> Till
>>>>
>>>