[1.10.0] flink-dist source jar is empty

[Steven Wu]

We build and publish flink-dist locally. But the source jar turns out empty. Other source jars (like flink-core) are good. Anyone else experienced similar problem?

Thanks,

Steven

[Chesnay Schepler]

That should not be a problem since the flink-dist module does not
contain any java sources

On 14/04/2020 06:42, Steven Wu wrote:
>
> We build and publish flink-dist locally. But the source jar turns out
> empty. Other source jars (like flink-core) are good. Anyone else
> experienced similar problem?
>
> Thanks,
> Steven

[Steven Wu]

flink-dist is a uber/shadow jar. before 1.10, its source jar contains the source files for the flink modules that it bundles.

On Tue, Apr 14, 2020 at 1:34 AM Chesnay Schepler <[hidden email]> wrote:

That should not be a problem since the flink-dist module does not
contain any java sources

On 14/04/2020 06:42, Steven Wu wrote:
>
> We build and publish flink-dist locally. But the source jar turns out
> empty. Other source jars (like flink-core) are good. Anyone else
> experienced similar problem?
>
> Thanks,
> Steven

[Chesnay Schepler]

I just built the 1.8 and 1.9 flink-dist jars and neither contain the sources of any bundled modules.

How were you building the jars, and were you making any modifications to the Flink source?

On 14/04/2020 15:07, Steven Wu wrote:

flink-dist is a uber/shadow jar. before 1.10, its source jar contains the source files for the flink modules that it bundles.

On Tue, Apr 14, 2020 at 1:34 AM Chesnay Schepler <[hidden email]> wrote:

That should not be a problem since the flink-dist module does not
contain any java sources

On 14/04/2020 06:42, Steven Wu wrote:
>
> We build and publish flink-dist locally. But the source jar turns out
> empty. Other source jars (like flink-core) are good. Anyone else
> experienced similar problem?
>
> Thanks,
> Steven

[Steven Wu]

Chesnay, sorry it was my mistake. yes, we did have a local change of for the shade plugin that I missed when porting local changes from 1.9 to 1.10. 

<createSourcesJar>true</createSourcesJar>

On Tue, Apr 14, 2020 at 6:29 AM Chesnay Schepler <[hidden email]> wrote:

I just built the 1.8 and 1.9 flink-dist jars and neither contain the sources of any bundled modules.

How were you building the jars, and were you making any modifications to the Flink source?

On 14/04/2020 15:07, Steven Wu wrote:

flink-dist is a uber/shadow jar. before 1.10, its source jar contains the source files for the flink modules that it bundles.

On Tue, Apr 14, 2020 at 1:34 AM Chesnay Schepler <[hidden email]> wrote:

That should not be a problem since the flink-dist module does not
contain any java sources

On 14/04/2020 06:42, Steven Wu wrote:
>
> We build and publish flink-dist locally. But the source jar turns out
> empty. Other source jars (like flink-core) are good. Anyone else
> experienced similar problem?
>
> Thanks,
> Steven